Repository navigation
FHIRPath cases for quantities with and without a unit - #314
Closed
oldrobotdev wants to merge 1 commit into
Closed
oldrobotdev wants to merge 1 commit into
oldrobotdev wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing this, because the cases in 09904dc cover the same thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test cases for hapifhir/org.hl7.fhir.core#2757, in r4, r4b, r5 and r6.
The new input observation-quantity-unit-only.xml has three components: 1 with the unit mg and no system, and two quantities of 1 with no unit. The cases check that =, !=, ~ and !~ give the same result in both orders when one quantity has a unit and the other has none (= and != are empty, ~ is false, !~ is true). They also check that 1 year = the unitless quantity is empty, and that the two unitless quantities are equal and equivalent.
The spec doesn't say how these quantities compare, so the cases use the result that core master already gives in one of the two orders. On master 7 of the 9 cases fail in each of the four engines, and all pass with the core PR.