Repository navigation
FHIRPath cases for unescape('json') of quotes and unicode escapes - #316
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test cases for hapifhir/org.hl7.fhir.core#2762, in r4, r4b, r5 and r6.
testUnescapeJson2 checks that unescape('json') reverses escape('json'), testUnescapeJson3 that \u0041B becomes AB, and testUnescapeJson4 that an escaped quote is unescaped. The existing testUnescapeJson has no backslash in its input, because the lexer turns " into " first, so it doesn't test the escape. On core master all 3 fail in each of the four engines (b1<2b and A0041B), and they pass with the core PR.