Lay every plugin out like core: src/<Bucket>/<Class>.php

[mastacontrola]

Plugins were left half-migrated by the namespacing work. Every class went into FOG\Plugins\<Plugin>, but the files stayed where they were — so a plugin declared FOG\Plugins\LDAP\LDAPManager out of a file called class/ldapmanager.class.php, and core carried a scan-and-cache mechanism (176 file_get_contents on a cold cache) to reconcile the two.

The layout now follows the namespace. A plugin is laid out exactly like core, and discovered by exactly the mechanism core uses on itself:

<plugin>/src/<Bucket>/<Class>.php   declares   FOG\Plugins\<Segment>\<Bucket>\<Class>

with the file name equal to the class name and strtolower(<Segment>) equal to the plugin's directory name.

The directory does not move. It is plugins.pName, the ?node= value, the <node>.view permission string and the js/ URL — so there is no schema migration, no URL change and no RBAC churn. Only the PHP moves.

Decision and reasoning: ADR 0035.

What moved where

From	To
class/*.class.php extending FOGController	src/Items/
class/*.class.php extending FOGManagerController	src/Managers/
class/*.class.php extending FOGBase	src/Util/
capone/reg-task/caponetasking.class.php	src/Util/CaponeTasking.php
pages/ hooks/ events/ reports/ tasks/	src/Pages/ Hooks/ Events/ Reports/ Tasks/

class/ splits three ways because it used to hold everything; which bucket a file belongs in is decided by what its class extends. Report classes keep their underscored names (LDAP_Report), exactly as core names its own, because the menu key, the base64 f parameter and the permission node are all derived from that name.

Every move is a git mv, so per-file history follows.

Gates

• tests/plugin-layout.test.php replaces plugins-are-namespaced.test.php. It holds all three rules — file name equals class name including case, path equals namespace, segment lowercases to the directory — plus a floor, no class_alias(), and no leftover pre-1.6 directory. The test it replaces matched on the six discovery suffixes and had no minimum count, so after this move it would have matched zero files, printed "ok: 0 plugin class file(s)" and exited 0.
• tests/references-resolve.test.php is new, and exists because core-references-are-qualified.test.php cannot see this failure. Bucketing means class NtfyHandler extends Ntfy now spans two namespaces: the bare name still names a class this tree declares, so the older gate stays green, php -l is happy, and the fatal arrives mid-request on a live server. This asks the question PHP asks — given this file's namespace and its use imports, does the name resolve?

All three layout rules and the resolution gate were mutation-verified (each made to fail before being trusted). Full suite: 15/15 green.

Third-party plugins

This breaks any plugin written against the pre-1.6 layout, and that was accepted deliberately as the price of one consistent way to write FOG code. The failure is loud rather than silent: a plugin directory with no src/ but with a class/ gets one line in the log naming itself and the guide. Porting is a file move and a namespace line — no logic changes — and §11b of docs/plugin-development.md is the port table.

Ordering

Old core with these plugins, or new core with the old plugins, is each a server with no working plugins. So this merges and tags v1.6.23 first, and the FOG_PLUGINS_VERSION pin moves in the same fogproject PR that teaches core the new layout.