Conversation
andriokha
commented
Sep 8, 2026
andriokha
commented
Member
- fix: updated CONFIG_REPO_URL is ignored
- fix: don't delete or overwrite .htaccess
For existing checkouts, updating the repo URL didn't take effect.
Drupal writes an .htaccess into the config directory to block web access to it. Since 5a3e75a the action's wipe-and-copy has been dotfile-aware on both sides, so a config repo carrying no .htaccess caused the site's to be deleted: a security regression. The .htaccess is not config: it belongs to the site repo. An updated one (eg. from a core update) lands there first, and any copy carried in the config repo may be stale. So the action now discards whatever the export brought and restores the site repo's own from the index, skipping any whose directory the current export no longer produces. The host script correspondingly keeps .htaccess out of the config repo, and drops one an earlier run committed. Test fixtures now carry differing content on each side (stale-htaccess in the config repo, site-htaccess in the site repo) so a test can't pass just because both match. test-existing-pr drops the .htaccess files from the config repo HEAD to cover the exact regression.
A workflow with a schedule trigger is auto-disabled after 60 days of repository inactivity, and the disable applies to the whole file: the push and pull_request runs stop silently along with the cron. That had already happened, so PRs were running only the host-script bats suite. The monthly run added little over the push/PR runs, and these tests hit real GitHub repos with real credentials. workflow_dispatch remains for ad-hoc runs.
fix: don't delete or overwrite .htaccess
ci: drop the schedule trigger from test.yml
To truly run them in parallel I'd need to add the run ID to the test branch names, which would make clean-up for failed teardowns more complicated (right now we can just delete everything with a prefix).
ci: run tests in serial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.