Skip to content

dealbot funds draining #681

Description

@SgtPooki

dealbot uses DEALS_PER_SP_PER_HOUR (currently set to 4) and MIN_NUM_DATA_SETS (currently set to 15) to start creating data-storage checks and creating data-sets for SPs.

This causes a problem when new SPs join, and they may just be testing things, or may only be ephemeral, and causes dealbot to spin up a ton of data-sets with them before we're sure that they are going to stick around.

to get around this, we should:

  1. keep the deny lists so we can exclude some SPs from testing entirely, and keep testing new SPs.
  2. create an EXPECTED_APPROVED list of SPS that were listed as approved and that we do the 15 data-sets and 4 data storage checks per hour for.
  3. any other SP (newly added, not blocked, or not expected_approved) gets maybe 1 data-storage check per 4 hours, and 1 data-set..

The EXPECTED_APPROVED list gives us a list of SPs that we know are already approved and expect to meet performance criteria, as well as a list of SPs that we are thinking about moving to approved.

cc @rjan90 @TippyFlitsUK

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

  • Status
    🎉 Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions