Skip to content

Revert "Revert "feat: ExampleSponsoredDataSet"" - #605

Merged
Kubuxu merged 2 commits into
mainfrom
revert-599-revert-540-feat/sponsored-data-set
Sep 16, 2026
Merged

Kubuxu merged 2 commits into
mainfrom
revert-599-revert-540-feat/sponsored-data-set

Conversation

@wjmelements

Copy link
Copy Markdown
Contributor

Reverts #599

@wjmelements
wjmelements requested a review from Kubuxu as a code owner September 3, 2026 16:48
@wjmelements
wjmelements marked this pull request as draft September 3, 2026 16:48
@FilOzzy FilOzzy added this to FOC Sep 3, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Sep 3, 2026
@FilOzzy FilOzzy moved this from 📌 Triage to ⌨️ In Progress in FOC Sep 3, 2026
@wjmelements
wjmelements marked this pull request as ready for review September 3, 2026 20:29

@Kubuxu Kubuxu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love pulling in another library for an "example" here, especially from a build-time standpoint, but let's merge it. We can't shift things around later. Ideally, this should live slightly separated from core contracts.

@github-project-automation github-project-automation Bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FOC Sep 3, 2026
@Kubuxu
Kubuxu merged commit 0204cc1 into main Sep 16, 2026
6 checks passed
@Kubuxu
Kubuxu deleted the revert-599-revert-540-feat/sponsored-data-set branch September 16, 2026 14:26
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants