Repository navigation
External MCP: e2e tests and docs (#823) - #829
Merged
07prajwal2000 merged 2 commits intoOct 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #823. Part of #799.
Why
The external MCP work (#820–#822) had no end-to-end coverage and no user docs.
What
testing/e2e/tests/externalMcp.test.ts): admin creates anmcpintegration with acfg:header and test connection lists the 6 tools; wrong key fails; creator gets 403 on create/update/delete and can read;settings.ai.agentMcpIntegrationssaves; dev usesdevConfigunless "same as prod" is on.apps/ai-gateway/src/agent/externalMcp.test.ts): realexecuteRun+buildAgent+ MCP clients against the math server with a scripted model, no Postgres/NATS. Covers approval pause and approve (result 5, one call), deny,@mention preload, servers outside the setting invisible, abort duringslow_addcloses clients. "Always" is checked withrunAgentdirectly, since jobs never carry it.integrations/mcp-servers.md(sidebar + index link);getting-started/ai-agents.mdgets "Use other MCP servers" and a Safety bullet (external calls always ask).Notes
name(test connection returns tools only), so production points at a server that refuses the call and development at one that answers.@fluxify/mcp-mathadded to e2e devDependencies; CI filters already covered it.