Skip to content

Support Azure blob storage - #131

Merged
akankshamahajan15 merged 5 commits into
FoundationDB:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/azure-support
Jun 19, 2026
Merged

akankshamahajan15 merged 5 commits into
FoundationDB:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/azure-support

Conversation

@tclinkenbeard-oai

Copy link
Copy Markdown
Contributor

This PR adds support for using Azure blob storage in addition to the existing S3 support

johscheuer
johscheuer previously approved these changes May 6, 2026

@johscheuer johscheuer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread joshua/joshua_model.py Outdated

@johscheuer johscheuer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the changes are rebased on the latest main, the test should be working again.

Co-authored-by: Johannes Scheuermann <johscheuer@users.noreply.github.com>

@johscheuer johscheuer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the test failures?

@mpatou-openai

Copy link
Copy Markdown

@johscheuer any updates ?

johscheuer
johscheuer previously approved these changes Jun 19, 2026

@johscheuer johscheuer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me.

…re-support

# Conflicts:
#	Dockerfile
#	joshua/joshua.py
#	joshua/joshua_model.py
#	k8s/agent-scaler/Dockerfile
#	test-requirements.txt
#	test_joshua_model.py
@akankshamahajan15
akankshamahajan15 merged commit 0667052 into FoundationDB:main Jun 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants