Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #323 +/- ##
========================================
Coverage 85.41% 85.41%
========================================
Files 10 10
Lines 377 377
========================================
Hits 322 322
Misses 55 55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
note: waiting on progress on #337 before merging this to develop |
| template: | ||
| bootstrap: 5 | ||
|
|
||
| reference: |
There was a problem hiding this comment.
@slager I added this section to group the package functions by type on the pkgdown site. I don't feel too strongly about the exact grouping, just that it's really helpful to group in some fashion like this - so if you have other ideas of how to do this feel free to revise!
| family = "Slager", | ||
| role = c("aut"), | ||
| email = "dslager@fredhutch.org") | ||
| person(given = "Kellie", |
There was a problem hiding this comment.
For some reason, when I build the site locally, I only see my name show up under developers. Not sure if that is just on my end - can you check? We should definitely have everyone's names here showing up on the site. Also, not sure if it's really accurate to have me listed as the maintainer, but I won't object too much if there isn't a natural other choice. @mayerbry do you have any thoughts about this?
kelliemac
left a comment
There was a problem hiding this comment.
I added a tweak to the site formatting (see changes I pushed) that I think is nice to bake in now - no conflict with what was already there, just an add-on.
Also see comment about whether the list of developers is rendering properly on the site - on my end I only see my name, but I'm not sure if that's how it looks to everyone. @slager can you please check and fix if needed?
Overall looks great, excited to push this through!
|
uh-oh now the tests are failing :( but it doesn't seem related to my recent code changes as fair as I can tell... |
|
fix for the underlying issue(s) in the CI is here: #364 let's merge that PR into develop, then port the changes over here to confirm that it resolves the CI issues. |
Description
Draft PR for auto-generated VISCtemplates website. You can preview the built site locally from this branch with
pkgdown::build_site().Related Issues
#313
FredHutch/VISCfunctions#119
Checklist
devtools::document