feat: add learning proposal review flow#1574
Open
xielixing wants to merge 2 commits into
Open
Conversation
xielixing
force-pushed
the
feature/learning-proposals
branch
from
July 16, 2026 07:58
47e207c to
71a3f15
Compare
added 2 commits
July 25, 2026 15:18
Add learning proposal contracts, desktop API wiring, and Web UI review surfaces so selected conversation context can be captured and approved as persistent learning.
…en analysis and apply - Phase 1 (contracts): add ConflictType/Conflict structs, rootCause/actionPlan/conflicts fields, AgentPatch apply_mode. Expand can_approve for AgentPatch. - Phase 5 (coordinator): add remote_connection_id/remote_ssh_host to InternalAgentExecutionRequest; new build_session_config_for_workspace_with_remote to pass remote context through internal agent sessions. - Phase 2 (analyzer): replace no-tool isolated classifier with read-tool-equipped agent (Read/Grep/Glob/LS/Skill/GetFileDiff); new prompt with rootCause analysis + 4-type conflict detection + actionPlan output. Delete ObservedSkillInvocation / LearningContextSnapshot / LearningContextLoader / build_context_snapshot / bounded_json_value / truncation and skill-invocation preprocessing (agent now reads SKILL.md itself). Inject ProvenanceValidator trait for testability. - Phase 4 (applier): add InternalAgentLearningProposalApplier for AgentPatch targets (Skill/AgentsMd); agent applies via Write/Edit tools with path policy restricted to workspace/skills/memory roots. Memory still uses direct ad_hoc note write + Phase2 consolidation. Delete create_memory_note direct fs::write for non-memory paths. Post-apply hash verification for local workspaces. - Phase 3 (UI): add rootCause/actionPlan/conflicts sections to review dialog; conflict badge rendering with 4 types; approve button switches to 'Apply via agent' for AgentPatch mode. i18n keys added for en-US/zh-CN/zh-TW.
xielixing
force-pushed
the
feature/learning-proposals
branch
from
July 25, 2026 09:12
8727454 to
6691c95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary