Skip to content

Turn on hypredrive by default - #4071

Open
rrsettgast wants to merge 13 commits into
developfrom
feature/addAdios2_addHypredrive
Open

Turn on hypredrive by default#4071
rrsettgast wants to merge 13 commits into
developfrom
feature/addAdios2_addHypredrive

Conversation

@rrsettgast

@rrsettgast rrsettgast commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Turns on hypredrive by default in GEOS

Note: we are not adding adios2 anymore in this branch, as suggested by its name

@rrsettgast
rrsettgast marked this pull request as ready for review June 1, 2026 14:05
@rrsettgast rrsettgast self-assigned this Jun 1, 2026
@rrsettgast
rrsettgast requested a review from victorapm June 1, 2026 14:05
@rrsettgast rrsettgast added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Jun 1, 2026
@rrsettgast

Copy link
Copy Markdown
Contributor Author

@victorapm

  • There are small numerical diffs in the integratedTests for a few tests.

  • There are no significant changes in this branch ( nor in the TPLs ) that should effect the image for the integratedTests EXCEPT:

    • hypredrive is on

    Can ENABLE_HYPREDRV ON change answers?

@rrsettgast

Copy link
Copy Markdown
Contributor Author

@victorapm Pretty sure that hypredrive is the source of failure. I will split the TPL work to separate ADIOS and hypredrive modifications, and repurpose this PR to just look at ADIOS, and create a new PR for hypredrive.

@victorapm victorapm self-assigned this Aug 1, 2026
@victorapm victorapm changed the title Adds Adios2, turns on hypredrive by default Turn on hypredrive by default Aug 15, 2026
@victorapm

Copy link
Copy Markdown
Contributor

@rrsettgast I figured out the remaining discrepancies between hypre and hypredrive and now CI is all green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants