Skip to content

core(navigation): suppress redirect warnings for error interstitials #17493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adityareddy-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

core(navigation): suppress redirect warnings for error interstitials #17493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cli/test/smokehouse/test-definitions/errors-expired-ssl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ const expectations = {
finalDisplayedUrl: /(expired.badssl.com|chrome-error)/,
runtimeError: {code: 'INSECURE_DOCUMENT_REQUEST'},
runWarnings: [
/expired.badssl.*redirected to chrome-error:/,
/The URL you have provided does not have a valid security certificate. net::ERR_CERT_(DATE|AUTHORITY)_INVALID/,
],
audits: {
Expand Down
3 changes: 2 additions & 1 deletion core/gather/driver/navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,8 @@ function getNavigationWarnings(navigation) {

if (navigation.timedOut) warnings.push(str_(UIStrings.warningTimeout));

if (!UrlUtils.equalWithExcludedFragments(requestedUrl, mainDocumentUrl)) {
if (!mainDocumentUrl.startsWith('chrome-error://') &&
!UrlUtils.equalWithExcludedFragments(requestedUrl, mainDocumentUrl)) {
warnings.push(str_(UIStrings.warningRedirected, {
requested: requestedUrl,
final: mainDocumentUrl,
Expand Down
13 changes: 11 additions & 2 deletions core/test/gather/driver/navigation-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,9 +341,18 @@ describe('.getNavigationWarnings()', () => {
expect(warnings).toHaveLength(0);
});

it('adds a url mismatch warning for failed navigations', () => {
it('does not add a url mismatch warning for error interstitials', () => {
const mainDocumentUrl = 'chrome-error://chromewebdata/';
const warnings = getNavigationWarnings({...normalNavigation, mainDocumentUrl});
expect(warnings).toHaveLength(1);
expect(warnings).toHaveLength(0);
});

it('keeps timeout warnings for error interstitials', () => {
const warnings = getNavigationWarnings({
...normalNavigation,
mainDocumentUrl: 'chrome-error://chromewebdata/',
timedOut: true,
});
expect(warnings).toEqual(getNavigationWarnings({...normalNavigation, timedOut: true}));
});
});
Loading