Repository navigation
Add the session operations for taking back, dropping and restoring interactions - #4868
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 9 files
Confidence score: 3/5
- The new GC-root set in
document/graph-storage/src/session.rsisn’t used by resource GC, so retracted resources can be evicted. RouteGdd::all_referenced_resource_hashesor its caller throughSession::resource_gc_roots.
You’re at about 97% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="document/graph-storage/src/session.rs">
<violation number="1" location="document/graph-storage/src/session.rs:984">
P2: The new GC-root set is never used by the actual resource-GC path. Route `Gdd::all_referenced_resource_hashes` or its caller through `Session::resource_gc_roots`, otherwise retracted resources can be evicted.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
TrueDoctor
force-pushed
the
graph-storage-11-session-ops
branch
from
October 31, 2026 07:54
f245640 to
f31f46a
Compare
TrueDoctor
force-pushed
the
graph-storage-11-session-ops
branch
from
October 31, 2026 09:06
f31f46a to
eac8d42
Compare
TrueDoctor
force-pushed
the
graph-storage-11-session-ops
branch
2 times, most recently
from
October 31, 2026 12:55
c416999 to
0f3c271
Compare
TrueDoctor
force-pushed
the
graph-storage-11-session-ops
branch
from
October 31, 2026 13:45
0f3c271 to
34f7354
Compare
…teractions and for following a retirer
TrueDoctor
force-pushed
the
graph-storage-11-session-ops
branch
from
October 31, 2026 15:37
34f7354 to
04c1dbf
Compare
6 of 51 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.