Fix premature OpenSearch transition during Data Node upgrade - #27138
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents premature transition to the OpenSearch upgrade phase during Data Node upgrades.
Changes:
- Requires current Data Node versions and enabled shard replication before transitioning.
- Retains pending-node state when replication startup fails.
- Adds regression coverage for phase transitions and marker cleanup.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
graylog2-web-interface/src/pages/DataNodeUpgradePage.tsx |
Updates phase detection and confirmation handling. |
graylog2-web-interface/src/pages/DataNodeUpgradePage.test.tsx |
Covers replication and stale-marker scenarios. |
graylog2-web-interface/src/components/datanode/hooks/useDataNodeUpgradeStatus.ts |
Clears pending state only after successful replication startup. |
graylog2-web-interface/src/components/datanode/hooks/useDataNodeUpgradeStatus.test.ts |
Tests pending-state retention and cleanup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vvasylenko
approved these changes
Aug 28, 2026
laura-b-g
approved these changes
Sep 7, 2026
laura-b-g
left a comment
laura-b-g
left a comment
Contributor
There was a problem hiding this comment.
Looking good, just a small comment. Nothing blocking
Comment on lines
+97
to
+99
| openSearchStatus === 'upgrading' || (areAllDataNodeVersionsUpToDate && data?.shard_replication_enabled === true); | ||
| const showOpenSearchUpgradeSection = | ||
| areAllDataNodesUpToDate && ['outdated', 'upgrading', 'unconfirmed'].includes(openSearchStatus); | ||
| isOpenSearchPhase && ['outdated', 'upgrading', 'unconfirmed'].includes(openSearchStatus); |
Contributor
There was a problem hiding this comment.
I think it would be nice to put the openSearchStatus in a as const
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/nocl
Description
Prevents the wizard from advancing to the embedded OpenSearch upgrade before the Data Node rolling upgrade is complete. It now waits until all Data Nodes are updated and shard replication is restored. Once the OpenSearch upgrade starts, its progress remains visible throughout the rolling restart.
Motivation and Context
fixes https://github.com/Graylog2/graylog-plugin-enterprise/issues/15320
Types of changes
Checklist: