Implement ProxyConfig class to encapsulate common proxy configuration logic. - #27306
Draft
dennisoelkers wants to merge 4 commits into
Draft
Implement ProxyConfig class to encapsulate common proxy configuration logic.#27306dennisoelkers wants to merge 4 commits into
ProxyConfig class to encapsulate common proxy configuration logic.#27306dennisoelkers wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Replace the raw URI field with Optional<ProxyConfig> to leverage the shared ProxyConfig value type from Task 1. The public API remains unchanged: getProxyAddress() still returns the same InetSocketAddress, and select() continues to call it dynamically for each proxy selection, supporting mock-based testing scenarios. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Prior to this PR, several different places handling optional proxy configuration logic did the same things for e.g. splitting potential credentials from the configured proxy URL. This PR is consolidating this by implementing a common
ProxyConfigclass./nocl Internal refactoring.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: