AB#730 Convert TileLayerContainer to a function component

[vesameskanen]

Proposed Changes

• Convert TileLayerContainer from a class component to a function component, using the useLeaflet and useCurrentTime hooks
• Fix the layer and its event parent never being removed on unmount
• Fix the vehicle-popup className leaking to later popups
• Remove unused/junk code (showSpinner, bogus popup options)
• Simplify with optional chaining and shared parking helper
• Keep popup content mounted while Leaflet fades the popup out, so the close cross no longer jumps on close
• Rewrite unit tests for the function component

Pull Request Check List

• A reasonable set of unit tests is included
• Console does not show new warnings/errors
• Changes are documented or they are self explanatory
• This pull request does not have any merge conflicts
• All existing tests pass in CI build

Review

• Read and verify the code changes
• Test the functionality by running the UI locally with all popular browsers available in your platform
• Check that the implementation matches the design, when such one is defined in an issue in Azure Boards
• Merge the pull request

[Antiik91]

Very strange behavior happened while testing:

Search route ie Tram 15 and select it. See the route line and rendered vehicle icons
Go back
Click trams in near you -> Map renders the Tram 15 line and the trams on that line.

This happens with every route I tested, couldn't verify the issue in production.

[hjvuor]

Very strange behavior happened while testing:

Search route ie Tram 15 and select it. See the route line and rendered vehicle icons Go back Click trams in near you -> Map renders the Tram 15 line and the trams on that line.

This happens with every route I tested, couldn't verify the issue in production.

I tested this cause it might've been my recent changes to the mapLayer context but couldnt reproduce (using this branch or v3), can you verify if this happens in v3/dev or just this branch

[Antiik91]

NVM, it seemed a bug because of selected location and selected routes showed strange looking results, but when investigating further it works as intended.

I tested with 2 different routes and Near you (with specific location), but it works as intended. Just looked odd :D