Skip to content

AB#724 Refactor mapLayerStore into react context - #6068

Merged
vesameskanen merged 6 commits into
v3from
AB#724-maplayers
Oct 9, 2026
Merged

vesameskanen merged 6 commits into
v3from
AB#724-maplayers

Conversation

@hjvuor

@hjvuor hjvuor commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

  • Refcators into react context with a provider and a custom hook that returns the layers and a update function

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in an issue in Azure Boards
  • Merge the pull request

@hjvuor
hjvuor marked this pull request as ready for review October 7, 2026 12:02
@hjvuor
hjvuor marked this pull request as draft October 8, 2026 13:22
@hjvuor
hjvuor marked this pull request as ready for review October 8, 2026 13:24

@vesameskanen vesameskanen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layer locking still needs some tuning:

  • citybikes near you shows 'vehicles' checked which is misleading. Locking is OK.
  • citybike, bike park and car park pages also show 'vehicles' checked. Locking is OK.
  • route page should lock and force disable car and bike parks

@vesameskanen
vesameskanen merged commit 3243f6c into v3 Oct 9, 2026
9 checks passed
@vesameskanen
vesameskanen deleted the AB#724-maplayers branch October 9, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants