Repository navigation
Conversation
…e feed startClient() passed configClient()'s result straight to startRealTimeClient without checking for null. configClient() returns null when the itinerary's feed isn't configured for realtime or the realtime source isn't active - e.g. special routes without a fixed schedule - which crashed mqttClient.js's startMqttClient on settings.options. Other call sites (RouteControlPanel, DepartureListContainer, updateClient) already guard against this; added the same guard here. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
vesameskanen
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
vesameskanen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
startRealTimeClientwith anullconfig whenever the route's feed wasn't configured for realtime or its realtime source wasn't active, which crashedmqttClient.js'sstartMqttClientonsettings.options.startClient()inItineraryPageUtils.jsnow guards against anullclient config the same wayRouteControlPanel,DepartureListContainer, andupdateClientalready do.CONFIG=hsl yarn run dev: reproduced the crash on/reitti/Martti, Turku::60.440986,22.253577/Kakola, Turku::60.44278,22.242233?time=1791437498ErrorBoundarychildrenis now optional (empty content, e.g. stop page alerts tab), and the embedded search generator preview passes a completematch(location.pathname,params) toEmbeddedSearch./haku) background graphic being hidden: the control panel became opaque white when its invalidbackground-color: ffffffwas corrected to#fff, so the panel is now explicitly transparent in the embed.config.secondaryLogo(light-background logo) instead of falling back to the navbar logo, which is often white. AddedsecondaryLogofor matka (new recolored SVG), varely, hsl, pori, jyvaskyla, kotka, turku, rovaniemi, tampere (favicon) and joensuu (new SVG); hameenlinna now uses its main logo (unusedsecondary-logo.pngremoved). Themes without one (e.g. default, waltti, kela, mikkeli) show no logo.Pull Request Check List
Review