Skip to content

AB#740 Modernize favourite-editing-modal - #6075

Merged
vesameskanen merged 15 commits into
v3from
AB#740
Oct 13, 2026
Merged

vesameskanen merged 15 commits into
v3from
AB#740

Conversation

@vesameskanen

@vesameskanen vesameskanen commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Rewrites favourite-editing-modal on the HSL design system, like favourite-modal in AB#739 (this branch includes AB#739, so merge that first).

  • Hooks function component on @hsl-fi/dialog Modal; delete confirmation uses the modernized DialogModal.
  • Removed isMobile, appElement, colors, fontWeights and t props. Styles use design-system tokens.
  • Dropped @hsl-fi/modal, @hsl-fi/sass and react-modal from the package; updated tests, README and translations.
  • Added @hsl-fi/loading-indicators as an explicit root dependency, since it was only resolved through workspace hoisting.

vesameskanen and others added 10 commits October 9, 2026 12:26
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vesameskanen
vesameskanen marked this pull request as ready for review October 9, 2026 12:50
@hjvuor
hjvuor self-requested a review October 12, 2026 12:24

@hjvuor hjvuor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When dragging to move favourites, the item is duplicated as transparent. Before it just moved the item to whatever direction it was dragged. Should this be fixed?
Image

…gModal

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vesameskanen

Copy link
Copy Markdown
Member Author

I can't see any change in dragging behaviour from previous version. Can you recheck please?

@vesameskanen
vesameskanen requested a review from hjvuor October 13, 2026 05:38
@hjvuor

hjvuor commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Ok it looks like the issue sometimes also appears on the old implementation but for some reason not always for me. I tried creating a ghostClass and a fallbackClass for the ReactSortable elements with opacities 0 and 1 and I think it improved the look, I can commit the change here so you can check

vesameskanen and others added 3 commits October 13, 2026 11:57
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
 - @digitransit-component/digitransit-component@6.0.0
 - @digitransit-component/digitransit-component-favourite-editing-modal@7.0.0
@vesameskanen
vesameskanen merged commit 0445b07 into v3 Oct 13, 2026
9 checks passed
@vesameskanen
vesameskanen deleted the AB#740 branch October 13, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants