Skip to content

refactor!: simplify setup and catalog configuration - #53

Merged
Zacaria merged 3 commits into
masterfrom
refactor/remove-legacy-50
Oct 14, 2026
Merged

Zacaria merged 3 commits into
masterfrom
refactor/remove-legacy-50

Conversation

@Zacaria

@Zacaria Zacaria commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #50

Intentional setup retirement

The owner approved retiring MCP-only connection setup in favor of bootstrap plus configure_index. Remove the credential-taking configure MCP tool, its unconfigured stdio startup path, and automatic checkout-catalog lookup. Credentials are set up by the operator and saved securely, not supplied through MCP tool arguments.

This deliberately retires a second setup workflow; it is not a claim that its code was dead. Hand-authored and generated catalogs remain supported with the same JSON schema, and existing catalog/profile files are not deleted. Direct environment startup requires an explicit catalog path or configuration-file store.

Supported behavior preserved

  • HTTP initialization/session IDs, handshake-free calls, GET/SSE, authenticated DELETE, cross-request cancellation, profile binding, bounded sessions and shutdown from PR feat(server): serve per-caller profiles over HTTP with pluggable cata… #47 are restored. Modern stateless requests remain supported.
  • setup connection flags remain accepted through the same Commander option registration and bootstrap runner. Bare setup stays guided; bare bootstrap is connection-only. The duplicate raw-argv parser is gone.
  • Real Kibana/Elasticsearch backend and schema variants, credential safety, catalog hashes/atomic writes/CAS protection, authentication, isolation, limits and cancellation remain supported.

Actual cleanup and corrections

  • Delete unused source-origin metadata, the unused single-source catalog overload, obsolete migration-only release guards and superseded implementation plans.
  • Clean generated root dist before compilation and reject packed JS/declaration outputs without current source. Proven stale deleted modules no longer ship after rebuild.
  • Isolate stdio tests from ambient saved profiles; correct onboarding environment cleanup, prompt guarantees and schema-fallback documentation.
  • Retain concise accepted installation requirements and historical live-backend observations rather than deleting unique evidence.

Verification

  • npm run verify: 371 tests / 44 files, types, lint, formatting, build, isolated copied-plugin handshake/discover, release contract and packlist passed.

  • npm run docs:build and git diff --check passed.

  • Independent source review: 21-path correction PASS, all 68 PR paths reconciled, 127 focused tests passed. The subsequent documentation-only delta review passed against final tree 420d9d8271567002ab17b1335f46ee7b5fe28285; every runtime, test, packaging and schema blob is unchanged from the reviewed source tree b8033e3f866de5ce3c02947bee7639606ec57a74. The owner-approved setup boundary is recorded in docs/project/support-policy.md.

  • HTTP suite: 24 legacy + 20 modern cases pass. Byte-unchanged original fixtures pass 23/24 against this candidate; the remaining startup diagnostic difference is intentional for the owner-approved configuration-workflow retirement, not a removed HTTP protocol capability.

  • No live Kibana, native credential store, interactive Codex registration, merge, release or deployment claimed.

  • PR title follows Conventional Commits.

Remove owner-only compatibility code, credential-taking MCP setup, implicit catalog fallbacks, legacy HTTP sessions, and obsolete migration guards/docs. Split guided setup from connection-only bootstrap and replace manual CLI parsing with Commander options.

BREAKING CHANGE: configure is removed. Startup requires a connection and an explicit catalog path or store. HTTP accepts only the current per-request protocol. setup no longer accepts bootstrap flags; use the bootstrap command.

Closes #50
Restore the HTTP session and handshake-free contracts added in PR #47, and retain setup connection flags through one Commander parser. Remove stale build artifacts before compilation and require package/source parity. Isolate stdio tests from ambient profiles, correct onboarding and schema docs, and retain unique requirements and historical backend evidence.

Fresh full verification: 371 tests across 44 files, types, lint, format, build, installed-plugin handshake, release and package contracts, and docs build. Independent exact-tree correction review passed 127 focused tests. Retirement of configure and its unconfigured setup flow remains an explicit open owner decision; this correction is not approval to merge or release that removal.
@Zacaria
Zacaria marked this pull request as draft October 14, 2026 00:30
@Zacaria Zacaria changed the title refactor!: remove legacy setup and transport paths refactor!: simplify setup and catalog configuration Oct 14, 2026
Record the owner-approved retirement of MCP-only connection setup in favor of bootstrap and configure_index. Existing catalog schemas and files are preserved. Runtime, tests, packaging and schemas remain byte-identical to the independently reviewed correction. Full verification passed 371 tests and all local gates; final documentation-only review approved the exact tree.
@Zacaria
Zacaria marked this pull request as ready for review October 14, 2026 01:04
@Zacaria
Zacaria merged commit 53eaa75 into master Oct 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup the legacy / compatibility code with ponytail

1 participant