Repository navigation
refactor!: simplify setup and catalog configuration - #53
Merged
Merged
Conversation
Remove owner-only compatibility code, credential-taking MCP setup, implicit catalog fallbacks, legacy HTTP sessions, and obsolete migration guards/docs. Split guided setup from connection-only bootstrap and replace manual CLI parsing with Commander options. BREAKING CHANGE: configure is removed. Startup requires a connection and an explicit catalog path or store. HTTP accepts only the current per-request protocol. setup no longer accepts bootstrap flags; use the bootstrap command. Closes #50
Restore the HTTP session and handshake-free contracts added in PR #47, and retain setup connection flags through one Commander parser. Remove stale build artifacts before compilation and require package/source parity. Isolate stdio tests from ambient profiles, correct onboarding and schema docs, and retain unique requirements and historical backend evidence. Fresh full verification: 371 tests across 44 files, types, lint, format, build, installed-plugin handshake, release and package contracts, and docs build. Independent exact-tree correction review passed 127 focused tests. Retirement of configure and its unconfigured setup flow remains an explicit open owner decision; this correction is not approval to merge or release that removal.
Zacaria
marked this pull request as draft
October 14, 2026 00:30
Record the owner-approved retirement of MCP-only connection setup in favor of bootstrap and configure_index. Existing catalog schemas and files are preserved. Runtime, tests, packaging and schemas remain byte-identical to the independently reviewed correction. Full verification passed 371 tests and all local gates; final documentation-only review approved the exact tree.
Zacaria
marked this pull request as ready for review
October 14, 2026 01:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50
Intentional setup retirement
The owner approved retiring MCP-only connection setup in favor of
bootstrapplusconfigure_index. Remove the credential-takingconfigureMCP tool, its unconfigured stdio startup path, and automatic checkout-catalog lookup. Credentials are set up by the operator and saved securely, not supplied through MCP tool arguments.This deliberately retires a second setup workflow; it is not a claim that its code was dead. Hand-authored and generated catalogs remain supported with the same JSON schema, and existing catalog/profile files are not deleted. Direct environment startup requires an explicit catalog path or configuration-file store.
Supported behavior preserved
setupconnection flags remain accepted through the same Commander option registration and bootstrap runner. Baresetupstays guided; barebootstrapis connection-only. The duplicate raw-argv parser is gone.Actual cleanup and corrections
distbefore compilation and reject packed JS/declaration outputs without current source. Proven stale deleted modules no longer ship after rebuild.Verification
npm run verify: 371 tests / 44 files, types, lint, formatting, build, isolated copied-plugin handshake/discover, release contract and packlist passed.npm run docs:buildandgit diff --checkpassed.Independent source review: 21-path correction PASS, all 68 PR paths reconciled, 127 focused tests passed. The subsequent documentation-only delta review passed against final tree
420d9d8271567002ab17b1335f46ee7b5fe28285; every runtime, test, packaging and schema blob is unchanged from the reviewed source treeb8033e3f866de5ce3c02947bee7639606ec57a74. The owner-approved setup boundary is recorded indocs/project/support-policy.md.HTTP suite: 24 legacy + 20 modern cases pass. Byte-unchanged original fixtures pass 23/24 against this candidate; the remaining startup diagnostic difference is intentional for the owner-approved configuration-workflow retirement, not a removed HTTP protocol capability.
No live Kibana, native credential store, interactive Codex registration, merge, release or deployment claimed.
PR title follows Conventional Commits.