Repository navigation
Multi-thread based AperturesMismatch: update source and tests - #31
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace mm_package_loader → prepare_mm_package (RegisterDriver v1.0.2 rename) - Update fixed_λ call: λ is now a keyword λt, not a positional arg (RegisterOptimize v1.0.0) - Convert Float32 arrays to Float64 before fixed_λ to work around Optim LBFGS passing Float64 internal buffers through Float32-typed gradient closures - Remove dead code: myconvert (defined but never called) - Add test/internals.jl: 4 cudatype tests covering both dispatch branches (coverage 63.7% → 67.4%; remaining gap is CUDA-only paths requiring GPU hardware) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 60.81% 65.55% +4.74%
==========================================
Files 1 1
Lines 74 90 +16
==========================================
+ Hits 45 59 +14
- Misses 29 31 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolved the world age issue by statically adding using RegisterMismatch (removed eval(:(using RegisterMismatch)))
Replaced Array{Any} in workers with explicitly typed arrays (Array{SVector}, Array{SMatrix})
Changed mmis handling from ArrayDecl-dependent logic to direct array creation followed by monitor! storage
Tests: migrated from addprocs/@everywhere/rmprocs to a threadids()-based approach
Tests: renamed variables pid= → tid=, and wpids → wtids
Tests: removed the pids= argument when creating SharedArray