Skip to content

Multi-thread based AperturesMismatch: update source and tests - #31

Merged
kdw503 merged 4 commits into
masterfrom
dwk/thread
May 21, 2026
Merged

kdw503 merged 4 commits into
masterfrom
dwk/thread

Conversation

@kdw503

@kdw503 kdw503 commented May 1, 2026 •

Copy link
Copy Markdown
Member

Summary

Resolved the world age issue by statically adding using RegisterMismatch (removed eval(:(using RegisterMismatch)))

Replaced Array{Any} in workers with explicitly typed arrays (Array{SVector}, Array{SMatrix})

Changed mmis handling from ArrayDecl-dependent logic to direct array creation followed by monitor! storage

Tests: migrated from addprocs/@everywhere/rmprocs to a threadids()-based approach

Tests: renamed variables pid= → tid=, and wpids → wtids

Tests: removed the pids= argument when creating SharedArray

kdw503 and others added 4 commits October 22, 2025 14:32
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace mm_package_loader → prepare_mm_package (RegisterDriver v1.0.2 rename)
- Update fixed_λ call: λ is now a keyword λt, not a positional arg (RegisterOptimize v1.0.0)
- Convert Float32 arrays to Float64 before fixed_λ to work around Optim LBFGS
  passing Float64 internal buffers through Float32-typed gradient closures
- Remove dead code: myconvert (defined but never called)
- Add test/internals.jl: 4 cudatype tests covering both dispatch branches
  (coverage 63.7% → 67.4%; remaining gap is CUDA-only paths requiring GPU hardware)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.55%. Comparing base (4f82a20) to head (ef857d5).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   60.81%   65.55%   +4.74%     
==========================================
  Files           1        1              
  Lines          74       90      +16     
==========================================
+ Hits           45       59      +14     
- Misses         29       31       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kdw503
kdw503 merged commit 50979e7 into master May 21, 2026
4 checks passed
@kdw503
kdw503 deleted the dwk/thread branch May 21, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant