Skip to content

Remove unused load_module / LoadModule code path - #56

Open
alsala wants to merge 2 commits into
devfrom
as/wasm_runtime_improvements
Open

alsala wants to merge 2 commits into
devfrom
as/wasm_runtime_improvements

Conversation

@alsala

@alsala alsala commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@alsala
alsala marked this pull request as ready for review July 28, 2026 07:11
@alsala
alsala requested a review from saratnt July 28, 2026 07:11

@saratnt saratnt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found by Claude:

  • CLAUDE.md:65 — export table still lists load_module(appId) / "Re-hydrate state on runtime start". Remove the row; re-hydration no longer involves a guest call.
  • runtime/wasm-go/README.md:79 — export table still lists load_module(appId); :63 lists LoadModule under app.go; :38 lists LoadModuleResult as a used result type. That table is stale beyond this change too — no deploy row, generate_deanonymization_report no longer exists, deposit signature omits token.

Comment thread runtime/wasm-go/go.mod

// Can be useful for local developments
//replace github.com/HorizenOfficial/vela => ../../../vela
replace github.com/HorizenOfficial/vela => ../../../vela

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thsi shouldn't be released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants