Skip to content
This repository was archived by the owner on Aug 4, 2026. It is now read-only.

Disconnect outbound peers on the invalid chain #387

Open

Description

@yixiao5428

This is a security vulnerability.

Currently, the outbound peers on incompatible chains may use up outbound connection slots (the ProcessMessage() function in src/main.cpp). If the block header is valid, but the block is known to be invalid, and the peer announces the same block as being on its active chain, the peer should be disconnected.

A possible solution is to check whether the first invalid header in mapBlockIndex is at the end, if not, disconnect the peer (after line 5758 in src/main.cpp).

Similar fix from Bitcoin: bitcoin/bitcoin@37886d5.

Reported by 6004ed5feaa31ae9df36b5dbc60f0fa53255a5fb734334082c6d202405fc738c.

Activity

  1. cronicc commented on Aug 3, 2021

    @cronicc
    Member

    Hi @yixiao5428

    I'm using this to respond for all the issues you've opened. First of all thank you for reporting them. We're currently focused on a major delivery of zend_oo and there is no further release planned from this repository. We will address all of the issues on the zend_oo repository in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions