Add contract number to projects#4906
Open
frjo wants to merge 7 commits into
Open
Conversation
wes-otf
requested changes
Jul 23, 2026
wes-otf
left a comment
Contributor
There was a problem hiding this comment.
This works really nice! Left a super nitpick of a comment.
Do you think it could also be squeezed into the invoice table? That was a request that came from staff as well. Could see that being useful on CSV export.
| verbose_name=_("Status"), accessor="get_status_display", order_by=("status",) | ||
| ) | ||
| fund = tables.Column(verbose_name=_("Fund"), accessor="submission__page") | ||
| contract_number = tables.Column(verbose_name=_("Contract nr."), default="-") |
Contributor
There was a problem hiding this comment.
How do you feel about this? 2 chars less and potentially a little more intuitive but maybe that's very english specific
Suggested change
| contract_number = tables.Column(verbose_name=_("Contract nr."), default="-") | |
| contract_number = tables.Column(verbose_name=_("Contract #"), default="-") |
Member
Author
There was a problem hiding this comment.
Change it to "Contract #" both in the table and on the project detail view now. Having it the same look better and less to translate.
frjo
force-pushed
the
feature/contract-number
branch
from
July 24, 2026 06:34
056c56d to
990f708
Compare
…t in PROJECTS_TABLE_EXCLUDED_FIELDS.
frjo
force-pushed
the
feature/contract-number
branch
from
July 24, 2026 06:50
990f708 to
00e7006
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4870
This PR adds a contract number field to the project detail view. It can be edited in a modal. It can be shown in the project table but is excluded by default via the
PROJECTS_TABLE_EXCLUDED_FIELDSsetting.Only staff, contracting and finance can edit the contract number but all who can view the project can see it.