Skip to content

Add contract number to projects#4906

Open
frjo wants to merge 7 commits into
mainfrom
feature/contract-number
Open

Add contract number to projects#4906
frjo wants to merge 7 commits into
mainfrom
feature/contract-number

Conversation

@frjo

@frjo frjo commented Jul 15, 2026

Copy link
Copy Markdown
Member

Fixes #4870

This PR adds a contract number field to the project detail view. It can be edited in a modal. It can be shown in the project table but is excluded by default via the PROJECTS_TABLE_EXCLUDED_FIELDS setting.

Only staff, contracting and finance can edit the contract number but all who can view the project can see it.

@frjo frjo added Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter labels Jul 15, 2026
@frjo
frjo requested a review from wes-otf July 19, 2026 15:33

@wes-otf wes-otf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works really nice! Left a super nitpick of a comment.

Do you think it could also be squeezed into the invoice table? That was a request that came from staff as well. Could see that being useful on CSV export.

Comment thread hypha/apply/projects/tables.py Outdated
verbose_name=_("Status"), accessor="get_status_display", order_by=("status",)
)
fund = tables.Column(verbose_name=_("Fund"), accessor="submission__page")
contract_number = tables.Column(verbose_name=_("Contract nr."), default="-")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about this? 2 chars less and potentially a little more intuitive but maybe that's very english specific

Suggested change
contract_number = tables.Column(verbose_name=_("Contract nr."), default="-")
contract_number = tables.Column(verbose_name=_("Contract #"), default="-")

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change it to "Contract #" both in the table and on the project detail view now. Having it the same look better and less to translate.

@frjo
frjo force-pushed the feature/contract-number branch from 056c56d to 990f708 Compare July 24, 2026 06:34
@frjo
frjo requested a review from wes-otf July 24, 2026 06:46
@frjo
frjo force-pushed the feature/contract-number branch from 990f708 to 00e7006 Compare July 24, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inputting, tracking & displaying of contract numbers for projects

2 participants