PS300: Add GPIB support - #975
Conversation
| <macro name="PORT" pattern="^COM[0-9]+$" description="Serial COM port" hasDefault="NO" /> | ||
| <macro name="MODEL" pattern="^[0-9]{3}((_neg)|(_pos))*$" description="Serial COM port" hasDefault="YES" defaultValue="350_pos"/> | ||
| <macro name="IPADDR" pattern="^[0-9]+\.[0-9]\.+[0-9]\.+[0-9]+$" description="IP Address of prologix GPIB" hasDefault="NO" /> | ||
| <macro name="GPIBADDR" pattern="^[0-9]+\.[0-9]\.+[0-9]\.+[0-9]+$" description="GPIB Address for prologix GPIB, usually 14" hasDefault="YES" defaultValue="-1" /> |
There was a problem hiding this comment.
- This regex does not look correct for an address that is "usually 14".
- If it really is "usually 14", then can it default to 14?
There was a problem hiding this comment.
The address macro gets passed via the asyn DB and so also goes to the serial interface as well as the gpib, for the serial wants -1. So i was being a bit lazy here, but i should add a second round of macro checks and if it is serial pass -1 for ADDR ratehr than GPIPADDR in which case it can default to 14
There was a problem hiding this comment.
I meant this regex: ^[0-9]+\.[0-9]\.+[0-9]\.+[0-9]+$ looks wrong, looks like it's meant to be for an IP address, but even then not convinced it works, I think it should be ^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$ instead for an IP address and just ^-?[0-9]+$ (not tested) for address
There was a problem hiding this comment.
Not sure what happened to IPADDR - i was assuming i has copied it from another IOC as we use it elsewhere!
I've removed need for -1 so i think ^[0-9]{1,2}$ covers it now for this device
2 participants
Description of work
Add GPIB as a connection option to the PS300 series of power supplies, some modeal have both serial and GPIB whereas others are just GPIB. Connection is via a prologix GPIB to ethernet adapter.
To test
Borrowed device is in end room if you wish to connect and test
See ISISComputingGroup/IBEX#8470
Acceptance criteria
Connects to device and can read back voltage and current pvs
galil-oldbranch based) and new (masterbranch based) drivers? If so have all appropriate PRs been created **Code Review
Functional Tests
..._0nwheren>1) run correctlymacLib: macroto find instances ofmacLib: macro [macro name] is undefined...Final steps