Repository navigation
🔨🤖 Install pre-commit as a uv tool so the git hook works in every worktree - #9908
Merged
sanderegg merged 6 commits intoOct 26, 2026
Merged
Conversation
github-actions
Bot
added
a:infra+ops
sanderegg
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66 and
wvangeit
as code owners
October 24, 2026 14:45
sanderegg
added
the
t:maintenance
pcrespov
approved these changes
Oct 25, 2026
pcrespov
reviewed
Oct 25, 2026
Member
Author
|
@mergify queue |
Contributor
Merge Queue Status🛑 Queue command has been cancelled |
GitHK
approved these changes
Oct 26, 2026
GitHK
left a comment
GitHK
left a comment
Contributor
There was a problem hiding this comment.
I see hooks go in user space now
Member
Author
@GitHK no as explained in the description, only pre-commit goes in user space. the hooks are attache into the repository (shared by all its worktrees actually). |
Contributor
correct I meant to say the library |
wvangeit
approved these changes
Oct 26, 2026
…tree Git worktrees share .git/hooks, and `pre-commit install` writes the path of the Python that ran it into the hook. With pre-commit in .venv, the hook pointed to the .venv of whichever worktree ran `make devenv` (or `pre-commit install`) last, and commits failed in every worktree once that .venv was removed or recreated. - `make devenv` installs pre-commit as a uv tool, removes it from .venv and installs the hook from the uv tool - `make clean-hooks` removes the hook from the common git dir, which also works inside a worktree - requirements/devenv.txt: drop pre-commit; */requirements/_tools.txt regenerated without --upgrade, so they only lose pre-commit and the packages only it needed Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CI installs with `uv pip sync requirements/ci.txt`, which installs only what the lockfiles list. pytest-simcore needs filelock, but the lockfiles only had it through pre-commit (virtualenv) in _tools.txt, so removing pre-commit broke every unit-test job. settings-library had pyyaml the same way and loads pytest_simcore.environment_configs, which imports yaml. _test.txt regenerated with `make reqs upgrade=filelock` (settings-library: `upgrade="filelock pyyaml"`); no other pin changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Track Renovate's uv constraint with the shared uv group, enable action digest pinning, remove the director Python exemption, and use explicit Valkey patch tags without changing image digests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sanderegg
force-pushed
the
maintenance/pre-commit-uv-tool
branch
from
October 26, 2026 08:30
0101f1a to
05e22de
Compare
Contributor
🛑 The queue request has been cancelled: new commits were pushedDetails@sanderegg pushed to this pull request after |
matusdrobuliak66
approved these changes
Oct 26, 2026
|
Member
Author
|
@mergify queue |
Contributor
Merge Queue Status
Waiting for
All conditions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
After pulling, run
make devenvonce in any worktree.What do these changes do?
Git worktrees share one pre-commit hook, and it pointed to the
.venvof the worktree that installed it last. Commits failed in all worktrees once that.venvwas gone.make devenvinstalls pre-commit as a uv tool and installs the hook from it.requirements/devenv.txtand from the_tools.txtfiles. They were regenerated without--upgrade, so versions stay the same.make clean-hooksalso works inside a worktree.filelock, which pytest-simcore needs, is added to the test requirements. The lockfiles only had it through pre-commit (andpyyamlin settings-library).Notes:
.pre-commit-config.yaml.uv tool upgrade pre-commitormake devenv.Bonus: Renovate and dependency tracking
Renovate now tracks its own pinned uv constraint in the shared uv update group, with a regression test, and enables GitHub Actions SHA pinning through
helpers:pinGitHubActionDigests(Renovate will propose the workflow conversions). The obsolete director frozen-service rule and Python-test exemption are removed. All five Valkey Compose references use the explicit7.2.14tag while retaining their existing image digest, so the deployed image is unchanged. Debian tracking/migration is not included. Validation: 9 focused Python/uv tests, pre-commit hooks (including Compose validation), and Pylint passed.Related issue/s
Split out of #9850.
How to test
Run
make devenv, thensed -n 6p .git/hooks/pre-commit. It prints the Python of the uv tool, not of.venv. Commit from a second worktree.Dev-ops
Developer tooling only.
Assisted-by: GitHub Copilot
Before and after
Before: the shared hook runs the
.venvof the worktree that ranmake devenvlast.After: the hook runs the per-user uv tool, whatever the worktree.