task: opensource coverity - #148
Open
jharlow-intel wants to merge 2 commits into
Open
Conversation
jharlow-intel
requested review from
vlad-perevezentsev and
xaleryb
as code owners
July 27, 2026 20:29
antonwolfy
reviewed
Jul 28, 2026
antonwolfy
reviewed
Jul 30, 2026
| # Forks lack the COVERITY_SCAN_* secrets; only run on the canonical repo. | ||
| if: github.repository == 'IntelPython/mkl_random' | ||
| runs-on: ubuntu-latest | ||
|
|
Collaborator
There was a problem hiding this comment.
Add timeout-minutes to prevent potential cov-build hanging
| ln -s "${rt_so[0]}" "${MKLROOT}/lib/libmkl_rt.so" | ||
| fi | ||
| echo "MKLROOT=${MKLROOT}" >> "$GITHUB_ENV" | ||
| echo "LD_LIBRARY_PATH=${MKLROOT}/lib:${LD_LIBRARY_PATH}" >> "$GITHUB_ENV" |
Collaborator
There was a problem hiding this comment.
If LD_LIBRARY_PATH is unset, ${MKLROOT}/lib:${LD_LIBRARY_PATH} writes .../lib: — a trailing empty element means "current directory" in the loader path, to fix that:
Suggested change
| echo "LD_LIBRARY_PATH=${MKLROOT}/lib:${LD_LIBRARY_PATH}" >> "$GITHUB_ENV" | |
| echo "LD_LIBRARY_PATH=${MKLROOT}/lib${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}" >> "$GITHUB_ENV" |
Comment on lines
+43
to
+44
| with: | ||
| fetch-depth: 0 |
Collaborator
There was a problem hiding this comment.
No need to fetch git history:
Suggested change
| with: | |
| fetch-depth: 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://scan.coverity.com/projects/intelpython-mkl_random?tab=overview
After reviewing their terms, seems we can use their open source dashboard and free scanner.
Set the scan to weekly to make sure we don't go over our quota