Implement chain adapater to read on chain protocol configurations by turmelclem · Pull Request #3482 · IntersectMBO/mithril

turmelclem · 2026-08-17T09:48:42Z

Content

This PR includes modification to implement chain adapater to read on chain protocol configurations :

Implement on-chain reader for protocol configurations
move mechanism checking configuration consistency in model
add markers implementation of MithrilNetworkConfigurationProvider
Implement a protocol configuration builder (used by Signer and Aggregator)
Wire MarkersMithrilNetworkConfigurationProvider in the Signer
Wire MarkersMithrilNetworkConfigurationProvider instead of local impl for leader aggregator
- tests have been adapted to read protocol configurations from makers instead of aggregator configuration
Refactor usage of parameters for protocol-configuration commands

Pre-submit checklist

Branch
- Tests are provided (if possible)
- Crates versions are updated (if relevant)
- CHANGELOG file is updated (if relevant)
- Commit sequence broadly makes sense
- Key commits have useful messages
PR
- All check jobs of the CI have succeeded
- Self-reviewed the diff
- Useful pull request description
- Reviewer requested
Documentation
- Update README file (if relevant)
- Update documentation website (if relevant)
- Add dev blog post (if relevant)
- Add ADR blog post or Dev ADR entry (if relevant)
- No new TODOs introduced

Relates to #3393

…igurations

…nsistency in model

…kConfigurationProvider

github-actions · 2026-08-17T10:11:06Z

Test Results

5 files ± 0 209 suites ±0 1h 0m 53s ⏱️ - 1h 35m 37s
3 381 tests - 69 3 381 ✅ - 69 0 💤 ±0 0 ❌ ±0
11 256 runs - 57 11 256 ✅ - 57 0 💤 ±0 0 ❌ ±0

Results for commit 4a79c83. ± Comparison against base commit 58b575a.

This pull request removes 76 and adds 7 tests. Note that renamed tests count towards both.

mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_out_of_bounds
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_too_large_for_circuit_range
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::indices_not_increasing
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_merkle_path_mismatch
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_swap_keep_merkle_path
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_wrong_verification_key
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_corrupt_sibling
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_flip_position
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_long
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_short
…

mithril-protocol-config ‑ builder::test::deserialize_adapter_config_from_json
mithril-protocol-config ‑ builder::test::rejects_adapter_config_with_invalid_verification_key
mithril-protocol-config ‑ builder::test::rejects_adapter_config_with_unknown_type
mithril-protocol-config ‑ cardano_chain::protocol_configuration_reader::test::test_cardano_chain_reader
mithril-protocol-config ‑ cardano_chain::protocol_configuration_reader::test::test_cardano_chain_reader_should_throw_error_on_invalid_cbor
mithril-protocol-config ‑ markers::tests::test_get_network_configuration_removes_unavailable_discriminants_when_config_missing
mithril-protocol-config ‑ markers::tests::test_get_network_configuration_retrieve_configurations_for_aggregation_next_aggregation_and_registration

♻️ This comment has been updated with latest results.

+pub enum AdapterConfig {
+    /// Cardano chain protocol configuration adapter
+    CardanoChain {
+        /// Cardano chain address
+        address: ChainAddress,
+
+        /// Verification key
+        verification_key: ProtocolConfigurationMarkersVerifierVerificationKey,
+    },
+
+    /// Fake protocol configuration adapter with default value at epoch 0 (for test usage)
+    Fake,
+}


+pub enum AdapterConfig {
+    /// Cardano chain protocol configuration adapter
+    CardanoChain {
+        /// Cardano chain address
+        address: ChainAddress,
+
+        /// Verification key
+        verification_key: ProtocolConfigurationMarkersVerifierVerificationKey,
+    },
+
+    /// Fake protocol configuration adapter with default value at epoch 0 (for test usage)
+    Fake,
+}


+    CardanoChain {
+        /// Cardano chain address
+        address: ChainAddress,
+
+        /// Verification key
+        verification_key: ProtocolConfigurationMarkersVerifierVerificationKey,
+    },


+    CardanoChain {
+        /// Cardano chain address
+        address: ChainAddress,
+
+        /// Verification key
+        verification_key: ProtocolConfigurationMarkersVerifierVerificationKey,
+    },


+    },
+
+    /// Fake protocol configuration adapter with default value at epoch 0 (for test usage)
+    Fake,


+    },
+
+    /// Fake protocol configuration adapter with default value at epoch 0 (for test usage)
+    Fake,


…r instead of local impl for leader aggregator

…guration commands

@@ -1,5 +1,7 @@
 mod test_extensions;

+use std::collections::{BTreeMap, BTreeSet};


turmelclem added 5 commits August 10, 2026 18:29

feature(protocol-config): Implement on-chain reader for protocol conf…

3f15391

…igurations

refactor(protocol-config): moving mechanism checking configuration co…

cb83d62

…nsistency in model

feature(protocol-config): add markers implementation of MithrilNetwor…

e746a67

…kConfigurationProvider

feature(protocol-config): Implement a protocol configuration builder

db71a98

feature(signer): Wiring MarkersMithrilNetworkConfigurationProvider

b93a8b1

turmelclem force-pushed the ctl/3393-implement-chain-adapater-to-read-on-chain-protocol-configurations-2 branch from 4f87a71 to cb72f72 Compare August 17, 2026 09:56

turmelclem force-pushed the ctl/3393-implement-chain-adapater-to-read-on-chain-protocol-configurations-2 branch from cb72f72 to 9a7ac9a Compare August 17, 2026 16:10

github-advanced-security AI found potential problems Aug 17, 2026

View reviewed changes

turmelclem self-assigned this Aug 18, 2026

turmelclem added 2 commits August 18, 2026 18:34

feature(aggregator): Wiring MarkersMithrilNetworkConfigurationProvide…

02149a7

…r instead of local impl for leader aggregator

refactor(aggregator): refactor usage of parameters for protocol-confi…

4a79c83

…guration commands

turmelclem force-pushed the ctl/3393-implement-chain-adapater-to-read-on-chain-protocol-configurations-2 branch from 9a7ac9a to 4a79c83 Compare August 18, 2026 16:36

github-advanced-security AI found potential problems Aug 18, 2026

View reviewed changes

Comment thread mithril-aggregator/tests/genesis_to_signing.rs

@@ -1,5 +1,7 @@

mod test_extensions;

use std::collections::{BTreeMap, BTreeSet};

Navigation Menu

Uh oh!

Implement chain adapater to read on chain protocol configurations - #3482

Implement chain adapater to read on chain protocol configurations#3482
turmelclem wants to merge 7 commits into
mainfrom
ctl/3393-implement-chain-adapater-to-read-on-chain-protocol-configurations-2

turmelclem commented Aug 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 17, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1,5 +1,7 @@
		mod test_extensions;

		use std::collections::{BTreeMap, BTreeSet};

Uh oh!

Conversation

turmelclem commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Pre-submit checklist

Uh oh!

github-actions Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

turmelclem commented Aug 17, 2026 •

edited

Loading

github-actions Bot commented Aug 17, 2026 •

edited

Loading