Fix/release 3.9.1

[vrrayz]

No description provided.

[traumschule]

Thanks! Merged, two are still flaky

FAIL test/proposals/hooks/useProposals.test.tsx (933 MB heap size)
  ● useProposals › Status: active | past › Status: active

    expect(received).toBeTruthy()

    Received: false

      33 |       expect(result.proposals.length).toBeGreaterThan(0)
      34 |       result.proposals.forEach((proposal) => {
    > 35 |         expect(proposalActiveStatuses.includes(proposal.status)).toBeTruthy()
         |                                                                  ^
      36 |       })
      37 |     })
      38 |

      at forEach (test/proposals/hooks/useProposals.test.tsx:35:66)
          at Array.forEach (<anonymous>)
      at Object.<anonymous> (test/proposals/hooks/useProposals.test.tsx:34:24)

FAIL test/forum/modals/CreatePostModal.test.tsx (6.892 s, 895 MB heap size)
  ● UI: CreatePostModal › Transaction success

    Unable to find an element with the text: Your post has been submitted.. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

    Ignored nodes: comments, <script />, <style />
    <body>
      <div />
    </body>

      117 |     })
      118 |
    > 119 |     expect(await screen.findByText('Your post has been submitted.')).toBeDefined()
          |                         ^
      120 |   })
      121 |
      122 |   it('Displays post deposit', () => {

      at waitForWrapper (../../node_modules/@testing-library/react/node_modules/@testing-library/dom/dist/wait-for.js:187:27)
      at findByText (../../node_modules/@testing-library/react/node_modules/@testing-library/dom/dist/query-helpers.js:101:32)
      at Object.<anonymous> (test/forum/modals/CreatePostModal.test.tsx:119:25)


Test Suites: 2 failed, 1 skipped, 111 passed, 113 of 114 total
Tests:       2 failed, 4 skipped, 701 passed, 707 total

[vrrayz]

Thanks! Merged, two are still flaky

FAIL test/proposals/hooks/useProposals.test.tsx (933 MB heap size)
  ● useProposals › Status: active | past › Status: active

    expect(received).toBeTruthy()

    Received: false

      33 |       expect(result.proposals.length).toBeGreaterThan(0)
      34 |       result.proposals.forEach((proposal) => {
    > 35 |         expect(proposalActiveStatuses.includes(proposal.status)).toBeTruthy()
         |                                                                  ^
      36 |       })
      37 |     })
      38 |

      at forEach (test/proposals/hooks/useProposals.test.tsx:35:66)
          at Array.forEach (<anonymous>)
      at Object.<anonymous> (test/proposals/hooks/useProposals.test.tsx:34:24)

FAIL test/forum/modals/CreatePostModal.test.tsx (6.892 s, 895 MB heap size)
  ● UI: CreatePostModal › Transaction success

    Unable to find an element with the text: Your post has been submitted.. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

    Ignored nodes: comments, <script />, <style />
    <body>
      <div />
    </body>

      117 |     })
      118 |
    > 119 |     expect(await screen.findByText('Your post has been submitted.')).toBeDefined()
          |                         ^
      120 |   })
      121 |
      122 |   it('Displays post deposit', () => {

      at waitForWrapper (../../node_modules/@testing-library/react/node_modules/@testing-library/dom/dist/wait-for.js:187:27)
      at findByText (../../node_modules/@testing-library/react/node_modules/@testing-library/dom/dist/query-helpers.js:101:32)
      at Object.<anonymous> (test/forum/modals/CreatePostModal.test.tsx:119:25)


Test Suites: 2 failed, 1 skipped, 111 passed, 113 of 114 total
Tests:       2 failed, 4 skipped, 701 passed, 707 total

Its been a while so i can't remember if active and past are part of the values for the status key and from the issue i checked the mock data testProposals and noticed it doesn't have proposals with status:active hence why it would always return false.

in packages\ui\src\proposals\hooks\useProposals.ts there's this type UseProposalsStatus = 'active' | 'past'
but in the mock data for testProposals there are different statuses and none of them make use of UseProposalsStatus type

The second case happens because src\forum\modals\PostActionModal\CreatePostModal didn't have the success message set here const [state, send] = useMachine( defaultTransactionModalMachine('There was a problem posting your message.', undefined), { context: { validateBeforeTransaction: true } } )

[traumschule]

Thanks again. Since the test started failing since #4887 I assume we should remove vetoed proposals from the mock data in test/_mocks/proposals/index.ts.. Closing this and will apply fix in #4927.