Add brake indicator to ThrottleBar - #55
Conversation
- Map "Brake (calculated)" from telemetry CSV to `TelemetrySample` - Add `get_brake_active` helper method based on a threshold > 0.5 - Add `ThrottleBarConfig` with `show_brake` flag (defaults to true) - Update `ThrottleBar` to render a red brake indicator box directly over the green throttle bar when `show_brake` is enabled and brake is active - Add a checkbox to `ThrottleBar`'s custom UI configuration panel - Update `default_config.json` to enable `show_brake` for the `ThrottleBar` component - Fix resulting build/test errors caused by adding new fields to `TelemetrySample` Co-authored-by: KacperSynator <62207289+KacperSynator@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Map "Brake (calculated)" from telemetry CSV to `TelemetrySample` - Add `get_brake_active` helper method based on a threshold > 0.5 - Add `ThrottleBarConfig` with `show_brake` flag (defaults to true) - Update `ThrottleBar` to render a red brake indicator box directly over the green throttle bar when `show_brake` is enabled and brake is active - Add a checkbox to `ThrottleBar`'s custom UI configuration panel - Update `default_config.json` to enable `show_brake` for the `ThrottleBar` component - Fix resulting build/test errors caused by adding new fields to `TelemetrySample` - Fix failing sync benchmark caused by uninitialized brake value Co-authored-by: KacperSynator <62207289+KacperSynator@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 4385e54 | Previous: 2db3e79 | Ratio |
|---|---|---|---|
pixel_copy_1080p/allocate_every_frame |
826419 ns/iter (± 7082) |
891477 ns/iter (± 2033) |
0.93 |
pixel_copy_1080p/reuse_buffer |
548846 ns/iter (± 4598) |
570143 ns/iter (± 4619) |
0.96 |
auto_correlate_gps_100_laps |
1511775 ns/iter (± 30510) |
1697048 ns/iter (± 33639) |
0.89 |
auto_correlate_gps_lissajous_12min |
65474665 ns/iter (± 731408) |
74198241 ns/iter (± 362246) |
0.88 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 3b170d0 | Previous: 9a70126 | Ratio |
|---|---|---|---|
pixel_copy_1080p/allocate_every_frame |
826155 ns/iter (± 6320) |
333928 ns/iter (± 5584) |
2.47 |
pixel_copy_1080p/reuse_buffer |
540923 ns/iter (± 16608) |
215977 ns/iter (± 11777) |
2.50 |
This comment was automatically generated by workflow using github-action-benchmark.
Extracted the ui and skia logic into `draw_brake_ui` and `draw_brake_skia` methods. Co-authored-by: KacperSynator <62207289+KacperSynator@users.noreply.github.com>
Extracted the ui and skia logic into `draw_brake_ui` and `draw_brake_skia` methods. Passed `painter` by reference instead of by value. Co-authored-by: KacperSynator <62207289+KacperSynator@users.noreply.github.com>
2 participants
Adds a binary brake indicator onto the existing ThrottleBar overlay, drawn as a red box that illuminates when the brake is engaged. Included configuration UI to toggle the feature and updated default configuration.
PR created automatically by Jules for task 9148402415438005509 started by @KacperSynator