Repository navigation
Conversation
Signed-off-by: Ankit Basu <ankitbasu14@gmail.com>
Effi-S
requested changes
Sep 15, 2026
…fuzz targets Signed-off-by: Ankit Basu <ankitbasu14@gmail.com>
Effi-S
requested changes
Sep 22, 2026
Effi-S
left a comment
Contributor
There was a problem hiding this comment.
@neetance Is zkatsnark is meant to be a first-class driver like zkatdlog?
-
make checks/fmt/lint/license: all loop overGO_MODULES, andx/token/core/zkatsnarkisn't in that list. -
nightly-fuzz.yml: the new entries use pkg:./x/token/core/zkatsnark/validatorand rungo test ${pkg}from repo root. That path is a different module, so it won't resolve either. the fuzz targets won't actually run!
So the suite passes locally but is invisible to the CI
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an end-to-end regression test suite for the
zkatsnarktoken driver and resolves key transfer action validation and signature verification requirements:regression_test.go):IssueandTransfer) end-to-end using real SNARK provers (SpendProver,OutputProver), circuits, and validators.validator_transfer_sig.go):TransferSignatureValidateto satisfy the common token framework validation contract.EnsureExhausted).TransferActionto hold and serialize original inputOutputDescriptions inInputTokens, ensuring ledger lookup and token key verification succeed during transfer validation.Testing
All tests pass