Repository navigation
fix: send job_id when creating metrics streams - #77
Merged
Merged
Conversation
Read LIGHTNING_JOB_ID env var and pass it directly as job_id when creating a metrics stream. This fixes experiment-to-job linkage for docker-based jobs where LIGHTNING_CLOUD_PROJECT_ID is not set, causing the cross-project guard to clear app_id.
tejapulagam
requested review from
ethanwharris,
justusschock,
owbone and
tchaton
as code owners
September 22, 2026 21:35
justusschock
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read LIGHTNING_JOB_ID env var and pass it directly as job_id when creating a metrics stream. This fixes experiment-to-job linkage for docker-based jobs where LIGHTNING_CLOUD_PROJECT_ID is not set, causing the cross-project guard to clear app_id.