feat: add BisonFi override templates

[bakasura980]

BisonFi publishes no IDL and is not an Anchor program, so this adds a raw byte-layout write path guarded by account size and magic, plus four templates on it: price, depth, spread and freshness.

Also introduces optional IDLs on templates, so a program without one no longer needs a reconstructed IDL in the repo.

Greptile Summary

The PR adds IDL-free BisonFi scenario templates backed by guarded raw byte-layout writes.

• Adds price, depth, spread, and freshness templates for BisonFi v3 pool accounts.
• Extends scenario contracts with optional IDLs, raw account guards, and integer/strided/slot encodings.
• Routes raw templates through account materialization while preserving the existing IDL-based path.
• Adds BisonFi integration coverage and supporting scenario documentation.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure eligible for this follow-up review remains.

No blocking failure remains.

Important Files Changed

Filename	Overview
crates/types/src/scenarios.rs	Adds optional template IDLs and guarded raw-layout encodings while retaining the existing scenario wire model.
crates/core/src/surfnet/svm.rs	Adds raw-template materialization before the IDL path and skips IDL registration for templates that do not carry one.
crates/core/src/scenarios/registry.rs	Registers four BisonFi templates through a new IDL-free collection-loading path.
crates/core/src/scenarios/protocols/bisonfi/overrides.yaml	Defines guarded byte offsets and encodings for BisonFi price, depth, spread, and freshness overrides.
crates/core/src/tests/bisonfi/mod.rs	Adds raw encoding, guard, scenario materialization, and mainnet-backed BisonFi coverage.
.github/workflows/openai-review.yml	Adds an automated pull-request review workflow that runs Codex and posts its final feedback.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Scenario override] --> B[Resolve target account]
  B --> C{Template has raw layout?}
  C -->|Yes| D[Check account size and magic]
  D --> E[Encode values at configured offsets]
  E --> F[Write modified account bytes]
  C -->|No| G[Resolve owner IDL]
  G --> H[Decode and update typed fields]
  H --> F

Loading

_{Reviews (11): Last reviewed commit: "fix(types): prevent slot encoding trunca..." | Re-trigger Greptile}

Context used:

• Knowledge Base — Scenario execution
• Knowledge Base — Shared data contracts

[github-actions]

• svm.rs:3015: Raw-layout overrides validate size/magic but not account ownership. A caller can target any matching 2,048-byte account, unlike the IDL path which selects by owner program. Include BisonFi’s program ID in RawLayout and reject accounts owned by another program before writing.

[github-actions]

• .github/workflows/openai-review.yml:2: Using pull_request means OPENAI_API_KEY is unavailable for PRs from forks, so the Codex step will fail for external contributors. Add a fork-aware condition or document/use a secure alternative trigger.

Tests couldn’t run because Rustup attempted to write outside the permitted workspace. No other actionable issues found.

[github-actions]

• P1 – Raw writes do not verify account ownership (svm.rs): An override can supply any account address; the raw path validates only size and magic. A matching account owned by another program could be corrupted. Include the expected owner/program ID in RawLayout and validate account.owner() before writing.

• P2 – Slot encoding truncates large u64 slots (scenarios.rs): Casting target_slot to i64 turns values above i64::MAX negative, causing them to encode as zero. Use checked u64 addition/subtraction based on the lead’s sign.

[github-actions]

• svm.rs:3047: Raw-layout overrides validate only size/magic, not account ownership. Because callers may replace the template’s address, any 2048-byte account beginning with the same header can be modified—even if it is not owned by BisonFi. Add the expected program owner to the raw-layout guard and verify account.owner() before writing.