Repository navigation
feat!: configurable User-Agent and HTTP engine - #93
Merged
Merged
Conversation
- add a `userAgent` parameter to the generated ClientConfiguration, installed with the Ktor UserAgent plugin; its default value is set by the new `userAgent` generator option - add an `engine` generator option: a fully qualified HttpClientEngineFactory, or "platform" to let Ktor select the engine of each platform (CIO supports HTTPS only on the JVM) - KMP projects generated by initApiClientSubproject depend on ktor-client-engine-defaults and use engine = "platform" - add the composable `httpClientAuthorizationStatements` module hook; BasicAuthModule uses it - document the browser limitations (User-Agent and Referer) BREAKING CHANGE: ClientConfiguration has a new `userAgent` parameter before `engine`, and defaultHttpClientConfig a new `userAgent` parameter before `httpClientAuthorization`: calls passing these arguments by position must be updated.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
userAgentparameter to the generated ClientConfiguration, installed with the Ktor UserAgent plugin; its default value is set by the newuserAgentgenerator optionenginegenerator option: a fully qualified HttpClientEngineFactory, or "platform" to let Ktor select the engine of each platform (CIO supports HTTPS only on the JVM)httpClientAuthorizationStatementsmodule hook; BasicAuthModule uses itBREAKING CHANGE: ClientConfiguration has a new
userAgentparameter beforeengine, and defaultHttpClientConfig a newuserAgentparameter beforehttpClientAuthorization: calls passing these arguments by position must be updated.