Skip to content

[WIP] Presets Training CTA Fix#2467

Open
Camji55 wants to merge 1 commit into
LoopKit:next-devfrom
Camji55:pull-request/presets-training-fix
Open

[WIP] Presets Training CTA Fix#2467
Camji55 wants to merge 1 commit into
LoopKit:next-devfrom
Camji55:pull-request/presets-training-fix

Conversation

@Camji55

@Camji55 Camji55 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@marionbarker

Copy link
Copy Markdown
Contributor

Test

✅ successful test (but the prior version worked for this phone)
❓ The behavior has changed - the continue button is also visible, you do not need to scroll down

Configuration

start with next-dev, commit 14b70bd
point Loop submodule to this PR and build on test phone with no loop installed.
SE 3rd gen running iOS 26.5.2

  • press and hold the green loop to skip onboarding therapy settings
  • do not bother to add pump or cgm
  • tap on presets and see the 4 initial presets
  • tap on + Start Required Training
  • all screens were accessible and I did not have to scroll to reach the continue button
    • the not needing to scroll is different behavior
    • not sure if requiring the user to scroll to the bottom of each screen is desired.

Note - with this phone I was able to complete the training without going to landscape mode and all of the continue rows were accessible and worked without this change. However, I understand this did not work with other phone models.

@Camji55 Camji55 changed the title Presets Training CTA Fix [WIP] Presets Training CTA Fix Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants