Skip to content

Add selected upstream media and quality-of-life improvements - #5

Merged
LucifersCircle merged 4 commits into
mainfrom
codex/upstream-quality-bundle
Sep 15, 2026
Merged

LucifersCircle merged 4 commits into
mainfrom
codex/upstream-quality-bundle

Conversation

@LucifersCircle

@LucifersCircle LucifersCircle commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Summary

Integrates the recommended and optional low-conflict improvements selected from open redlib-org/redlib pull requests:

The imported search CSS's trailing whitespace was removed. The existing RSS code was formatted and six current Clippy findings were corrected without changing their intended behavior. No rate-limit-resilience behavior was replaced.

Verification

Passed:

  • Three-way merge checks against the fork's current main
  • Combined application of all twelve selected PRs
  • GitHub Docker workflow: cargo check --locked --all-targets
  • GitHub Docker workflow: all deterministic resilience tests
  • cargo fmt --all -- --check
  • cargo clippy -- -D warnings
  • git diff --check
  • node --check static/downloadGallery.js
  • node --check static/playHLSVideo.js

Known upstream/network-dependent failure:

  • The full cargo nextest run job fails only at oauth::tests::test_generic_web_backend, which makes a live Reddit request.
  • It failed all configured retries on two workflow attempts.
  • This bundle does not change src/oauth.rs or that backend. The deterministic OAuth, client, compile, formatting, and Clippy checks pass.
  • Docker publishing is correctly skipped for pull requests; merging to main will trigger the normal multi-platform image publication.

Normalizes the upstream RSS code already present on main so the repository-wide rustfmt PR check passes.
Applies behavior-preserving fixes for warnings promoted to errors by the pull-request workflow, including the imported CMAF URL formatter and pre-existing RSS/duplicates code.
@LucifersCircle
LucifersCircle merged commit 3b23b42 into main Sep 15, 2026
4 of 5 checks passed
@LucifersCircle
LucifersCircle deleted the codex/upstream-quality-bundle branch September 15, 2026 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant