Show inline error for wrong album password instead of opening login - #4665
Show inline error for wrong album password instead of opening login#4665matthewbolding wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (22)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe album unlock dialogs in v7 and v8 now show an inline invalid-password message for 403 responses. The message clears when the password changes or the unlock succeeds. Other errors retain the existing failure behavior. ChangesAlbum unlock feedback
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to The PR keeps album-unlock dialogs open and shows an inline error for wrong passwords, while other failures retain existing behavior. It is mergeable with owner awareness of the unresolved component-guideline violation in the v8 dialog. Poem
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 23 files. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a94058d0-70d2-4ff6-b4c7-5e8bb8284240
📒 Files selected for processing (3)
lang/en/dialogs.phpresources/js/v7/components/forms/album/Unlock.vueresources/js/v8/components/forms/album/Unlock.vue
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.
ildyria
left a comment
ildyria
left a comment
There was a problem hiding this comment.
LGTM, just need to fix the translations keys :)
Remaining langs updated to have the |
|
Disregard request to re-review; misclick. @ildyria |
2 participants
Summary
When an album is password-protected and the wrong password is entered, the unlock dialog currently closes and the site-wide login form opens instead, with no indication the password itself was wrong.
This makes the unlock dialog stay open and show an inline error on a 403 response, so the user can just retry the password. Other failure types keep the existing fallback behavior. Applied to both the v7 and v8 Unlock dialogs, following the same pattern already used in LoginForm.vue.
Test plan
npm run format— no changesnpm run check(vue-tsc) — passesnpm run build— succeedsSummary by CodeRabbit
Bug Fixes
Localization