AWS crash fix

[ildyria]

Fixes #4666

Summary by CodeRabbit

• Bug Fixes
  • Improved cloud storage URL handling by removing trailing slashes and preventing malformed links.
  • Updated security policies to recognize configured cloud storage origins consistently.
  • Improved loading of images, media, and other stored assets hosted on cloud storage.
  • Added safer defaults when storage configuration values are missing or empty.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 30f95edd-c2d3-4654-91ef-4d05cac1087c

📥 Commits

Reviewing files that changed from the base of the PR and between b557c36 and 7f3fb4a.

📒 Files selected for processing (1)

• config/secure-headers.php

🚧 Files skipped from review as they are similar to previous changes (1)

• config/secure-headers.php

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

---

📝 Walkthrough

Walkthrough

The S3 URL and CSP configuration now normalize AWS_URL by removing trailing slashes. A shared normalized origin supplies the CSP image, media, and object sources.

Changes

AWS URL configuration

Layer / File(s)	Summary
Normalize AWS URL values config/filesystems.php, config/secure-headers.php	The S3 URL and CSP origin use guarded environment access and remove trailing slashes from AWS_URL.
Reuse CSP origin config/secure-headers.php	The image, media, and object CSP sources use the shared normalized origin.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🟡 Moderate · up to 7f3fb

Unset AWS_URL values can produce relative S3 links and break access in affected deployments, so this change is not merge-ready until the configuration handling is fixed or explicitly accepted.

Poem

A rabbit trims the trailing slash

AWS_URL now fits with flash
One origin feeds each CSP line
S3 follows the same design
Config hops cleanly down the path

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9e46e87f-03f6-4ba4-9b47-2fcc72e72a01

📥 Commits

Reviewing files that changed from the base of the PR and between 30b99fd and b557c36.

📒 Files selected for processing (2)

• config/filesystems.php
• config/secure-headers.php

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.