GH action maintenance - #31
Conversation
027546d to
e621b00
Compare
orbeckst
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
- updated to use miniforge3 with conda-incubator/setup-miniconda - remove defaults channel use from CI
- updated CHANGELOG and pyproject.toml - CI tests were updated previously
68d6579 to
e5c8462
Compare
| @@ -30,17 +30,17 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [macOS-latest, ubuntu-latest, windows-latest] | |||
There was a problem hiding this comment.
I may comment out windows-latest for now until MDAnalysis/install-mdanalysis#14 is resolved.
There was a problem hiding this comment.
Switching the installer for the MDA action to conda seems a workaround.
There was a problem hiding this comment.
works with action from PR MDAnalysis/install-mdanalysis#16 so keep windows-latest
See if this helps with failure to run windows-latest / latest CI
| version: ${{ matrix.mdanalysis-version }} | ||
| install-tests: true | ||
| installer: mamba | ||
| installer: conda |
There was a problem hiding this comment.
|
@IAlibay do want to have a quick glance at the update? Primarily you may be interested in the problem with the mdanalysis-install action. Otherwise I can also self-merge. |
|
Once this is working, we can look at incorporating PR #22 |
|
I'll try if MDAnalysis/install-mdanalysis#16 fixes this issue by temporarily bundling the fixed (?) action. |
| - name: Install MDAnalysis version | ||
| uses: MDAnalysis/install-mdanalysis@main | ||
| #uses: MDAnalysis/install-mdanalysis@main | ||
| uses: MDAnalysis/install-mdanalysis@44cf01496714f057c094d1e9bad304bf91fc1b17 |
There was a problem hiding this comment.
This is the action in PR MDAnalysis/install-mdanalysis#16 ; once the PR is merged, this action needs to be changed again.
| exclude: | ||
| #exclude: | ||
| # The latest release of MDAnalysis only supports up to Python 3.11 | ||
| # so we exclude 3.12 from the test matrix (issue #20) | ||
| - python-version: "3.13" | ||
| mdanalysis-version: "latest" | ||
| #- python-version: "3.12" | ||
| # mdanalysis-version: "latest" |
There was a problem hiding this comment.
no exclusions needed, remove
| @@ -30,17 +30,17 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [macOS-latest, ubuntu-latest, windows-latest] | |||
There was a problem hiding this comment.
works with action from PR MDAnalysis/install-mdanalysis#16 so keep windows-latest
1 participant
Fixes #30 and #28
Changes made in this Pull Request:
PR Checklist