Repository navigation
connected_components: fix off-by-one bounds check in toggle_axis() - #3450
Merged
jdtournier merged 1 commit intoOct 15, 2026
Merged
jdtournier merged 1 commit into
jdtournier merged 1 commit into
Conversation
Connector::Adjacency::toggle_axis() resized enabled_axes only when axis > enabled_axes.size(), so toggle_axis(enabled_axes.size(), ...) indexed one past the end of the vector instead of growing it first.
Lestropie
approved these changes
Oct 12, 2026
Lestropie
left a comment
Lestropie
left a comment
Member
There was a problem hiding this comment.
Fix looks correct to me; TY!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connector::Adjacency::toggle_axis() resized enabled_axes only when axis > enabled_axes.size(), so toggle_axis(enabled_axes.size(), ...) indexed one past the end of the vector instead of growing it first.