Repository navigation
mrview: Fix fill tool texture format in ROI editor - #3451
Merged
Merged
Conversation
When the ROI texture internal format was updated to GL_R8UI, ROI_UndoEntry::draw_fill() was overlooked and continued to call glTexSubImage3D() with GL_RED instead of GL_RED_INTEGER. According to the OpenGL specification, updating an integer internal format texture requires an integer format parameter; passing GL_RED generates a GL_INVALID_OPERATION error on strict drivers and translation layers (such as newer macOS versions), causing fill updates to fail.
Member
jdtournier
approved these changes
Oct 15, 2026
jdtournier
left a comment
jdtournier
left a comment
Member
There was a problem hiding this comment.
Confirm fill tool wasn't working on master, but works with this change. 👍
(on my Arch AMD Ryzen 9 3950X / AMD RX 590 system)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ROI texture internal format was updated to GL_R8UI, ROI_UndoEntry::draw_fill() was overlooked and continued to call glTexSubImage3D() with GL_RED instead of GL_RED_INTEGER. According to the OpenGL specification, updating an integer internal format texture requires an integer format parameter; passing GL_RED generates a GL_INVALID_OPERATION error on strict drivers and translation layers (such as newer macOS versions), causing fill updates to fail.