Repository navigation
CI fix on dev - #3456
Open
Lestropie wants to merge 6 commits into
Open
CI fix on dev#3456Lestropie wants to merge 6 commits into
Lestropie wants to merge 6 commits into
Conversation
Required for Qt6 compatibility.
Hard-coded GCC-9 not available in 26.04 base image.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
Differences in streamline-to-voxel mapping are known to manifest across platforms / compilation environments; for voxels of low streamline density where the density and/or orientations change as a consequence, testing SH coefficients relative to the maximal SH coefficient value in the voxel may be unstable.
Found to fail on Linux GCC after bumping from version 9 to 15.
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to resolve CI issues observed in #3455.