Repository navigation
Fix #1801: after_gather plugins executed multiple times - #1802
Merged
Merged
Conversation
… it so it's only called when gather is actually done
Test Results410 tests 409 ✅ 1m 49s ⏱️ Results for commit 3bed7a9. |
andreleblanc11
approved these changes
Oct 16, 2026
andreleblanc11
left a comment
andreleblanc11
left a comment
Member
There was a problem hiding this comment.
I've known this was a problem for a while, but it didn't affect the output of the plugin I was working on so I never bothered to fix it. This seems like a good fix at first glance.
Member
Author
|
Every test is failing, but it's because sarrac is not installing. Launchpad is probably down (again). I'll wait until next week to merge but I'm testing on ddsr-dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1801, if we agree that it's actually a bug.
This changes the code so after_gather callbacks are executed after gathering. Currently they get triggered multiple times (once per gather plugin, which is usually 3 in subscribing components:
[<bound method Message.gather of <sarracenia.flowcb.gather.message.Message object at 0x7f13fee45400>>, <bound method Retry.gather of <sarracenia.flowcb.retry.Retry object at 0x7f13fee459b0>>, <bound method Log.gather of <sarracenia.flowcb.log.Log object at 0x7f13fe5ab518>>]).