Do not mask the render error with "Parent has not been set" - #1587
Merged
Conversation
When rendering an attribute with a render setting failed, parseValue() retried with the
default render settings and carried the parent over from the failing setting:
$objSettingsFallback = $this->getDefaultRenderSettings()->setParent($objSettings->getParent());
Render settings created on the fly have no parent - getDefaultRenderSettings() builds
them without one - so getParent() threw "Parent has not been set" and replaced the real
error with a misleading one. The FIXME in that line said exactly that.
Parsing an item without a render setting collection runs into this: parseValue() falls
back to the default render settings, and any attribute failing to render (in the case at
hand a text attribute holding an array, which makes the template raise "Array to string
conversion") ends in a 500 that points at the parent instead of the actual problem.
The parent is now only carried over when the failing setting has one, and a failure of
the fallback rendering re-throws the original exception instead of its follow-up error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendering an attribute with a render setting failed, parseValue() retried with the default render settings and carried the parent over from the failing setting:
Render settings created on the fly have no parent - getDefaultRenderSettings() builds them without one - so getParent() threw "Parent has not been set" and replaced the real error with a misleading one. The FIXME in that line said exactly that.
Parsing an item without a render setting collection runs into this: parseValue() falls back to the default render settings, and any attribute failing to render (in the case at hand a text attribute holding an array, which makes the template raise "Array to string conversion") ends in a 500 that points at the parent instead of the actual problem.
The parent is now only carried over when the failing setting has one, and a failure of the fallback rendering re-throws the original exception instead of its follow-up error.