Skip to content

feat: remove lightning - #337

Merged
stephantul merged 5 commits into
mainfrom
remove-lightning
Aug 3, 2026
Merged

feat: remove lightning#337
stephantul merged 5 commits into
mainfrom
remove-lightning

Conversation

@stephantul

Copy link
Copy Markdown
Contributor

This PR removes all references to lightning and pytorch lightning. Scores are (on average) identical for classification, but the new training loop is faster. Since the core training loop is shared by all training variants, I have high confidence that this also works for multi-label and regression tasks.

@stephantul
stephantul requested a review from Pringled August 1, 2026 18:43
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.31034% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
model2vec/train/trainer.py 99.01% 1 Missing ⚠️
Files with missing lines Coverage Δ
model2vec/train/__init__.py 100.00% <ø> (ø)
model2vec/train/base.py 97.91% <100.00%> (-0.17%) ⬇️
model2vec/train/classifier.py 98.27% <100.00%> (+0.14%) ⬆️
model2vec/train/regression.py 100.00% <100.00%> (ø)
model2vec/train/similarity.py 100.00% <100.00%> (ø)
model2vec/train/utils.py 100.00% <100.00%> (ø)
model2vec/train/trainer.py 99.01% <99.01%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pringled Pringled left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Two small comments but looks good to me

Comment thread model2vec/train/trainer.py Outdated
Comment thread model2vec/train/base.py
@stephantul
stephantul merged commit f9e7614 into main Aug 3, 2026
11 checks passed
@stephantul
stephantul deleted the remove-lightning branch August 3, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants