Repository navigation
fix(playback): support standalone demo checkpoints - #2558
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_config.jsonas a standalone file using the existing explicit no-source-run behavior, while preserving strict validation for ordinary runs and checkpoints with snapshotsmap_locationwhen rsl-rl loads a checkpoint, fixing CUDA-saved weights on CPU and MPSuv run demo dancewithout adding assets or dependenciesLinked Work
mainValidation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run:
uv run pytest tests/visualization/test_interactive_playback.py uv run demo dance make check make test make test-all uv buildResults:
uv run demo dancecompleted 1000 playback frames and video rendering with exit code 0.9954e648fab8af4360c683494264cbd177c49041:make test-allpassed, including 2760 passed / 137 skipped / 375 deselected with coverage, plus benchmark smoke module mode 35/35 and script mode 36/36.uv buildon the final head: sdist and wheel both built successfully; checkpoint, motion, video, ONNX, and teaser scene runtime-asset checks returned empty lists.Remote CI route:
main: all applicable current-head checks passed for9954e648fab8af4360c683494264cbd177c49041: CI run, documentation run.Impact
mujocodemo playback; shared rsl-rl checkpoint loadingArtifacts
Checklist