Avoid flaky authenticated Git fetch for nanobench - #282
Open
scal444 wants to merge 1 commit into
Open
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| .github/workflows/cpp-build-test.yml | Disables persisted checkout credentials; subsequent workflow operations do not rely on them. |
| cmake/nanobench.cmake | Replaces the nanobench Git clone with a versioned, checksum-verified archive while preserving the existing FetchContent integration. |
Reviews (1): Last reviewed commit: "Avoid authenticated Git clone for nanobe..." | Re-trigger Greptile
Collaborator
Author
|
Hoping this removes the inconsistent failures |
evasnow1992
approved these changes
Aug 24, 2026
evasnow1992
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for fixing this random credential issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++ configure job intermittently receives an authentication challenge while cloning the public nanobench repository. The checkout action persists a GitHub-wide authorization header in the checkout Git config, and CMake runs the dependency clone beneath that checkout. Using an archive removes the Git smart-HTTP and credential-inheritance path entirely; disabling credential persistence prevents similar unintended authentication in later commands.