Repository navigation
fix(moe): align HybridEP capacity growth with kernel chunk sizes - #7913
Draft
jalbericiola wants to merge 2 commits into
Draft
jalbericiola wants to merge 2 commits into
jalbericiola wants to merge 2 commits into
Conversation
Signed-off-by: Jorge Albericio <jalbericiola@nvidia.com>
Signed-off-by: Jorge Albericio <jalbericiola@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ragged batches can grow HybridEP's token reservation to a capacity that violates the installed dispatch/combine kernels' chunk alignment. Derive a common alignment from their configured chunk sizes and apply it to initial and grown reservations. Release unused Torch allocator cache before raw CUDA allocation growth so free cached memory is available to the external allocator.
The change affects reserved capacity, not actual token counts, routing probabilities or losses. It applies without shared-prefix execution. The tests cover alignment, growth without shrinking, invalid chunk sizes and the cache-release call.
Validation and review status
Merged
mainatcff9cf4e0935311ca12faa84820f2d329c17271awithout conflicts. The PR remains scoped to the capacity helper changes and their tests.tools/autoformat.shworkflow passes its Black, isort, pylint and Ruff gates;git diff --checkpasses.This remains a draft pending real GPU allocator and dispatch/combine backward qualification across a capacity boundary with the supported DeepEP version.