Skip to content

Inference: properly size barrier slots for symmetric memory allocations - #8030

Open
adistomar wants to merge 5 commits into
NVIDIA:mainfrom
adistomar:aditya/signal-pad-ptrs-size
Open

adistomar wants to merge 5 commits into
NVIDIA:mainfrom
adistomar:aditya/signal-pad-ptrs-size

Conversation

@adistomar

@adistomar adistomar commented Oct 9, 2026 •

Copy link
Copy Markdown
Member
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

The default size of the signal pad ptrs array is 32 * 72 * 4 (https://github.com/yang-yu-hang/pytorch/blob/main/torch/csrc/distributed/c10d/symm_mem/CUDASymmetricMemoryTypes.hpp#L25-L27). The 32 is assumed to be default number of blocks, 72 accounts for all GPUs in NVL72 domain, and 4 is 4 bytes per value, since each barrier slot is an int32.

However for larger number of blocks, ranks will be writing out of the memory region allocated for the signal pad ptrs, so we should explicitly set the size of the barrier slots as a function of world size and the number of blocks.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • If this PR adds or changes a GPU kernel (Triton, jit_fuser/torch.compile, CUDA extension, TE or external-library dispatch, or a scatter/index accumulation), I have added or updated its bit-exact determinism test and registered it in tests/unit_tests/determinism/kernels/manifest.py (guide)
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

@adistomar
adistomar requested review from a team as code owners October 9, 2026 21:26
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft October 9, 2026 21:26
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@adistomar
adistomar marked this pull request as ready for review October 9, 2026 21:26
@adistomar
adistomar enabled auto-merge October 9, 2026 21:27
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Oct 9, 2026
… blocks

Signed-off-by: adistomar <adityatomar2604@gmail.com>
Signed-off-by: adistomar <adityatomar2604@gmail.com>
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Oct 10, 2026
@nemo-automation-bot

Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/38123948935

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 11, 2026

This branch was successfully deployed

2 active deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low determinism-exempt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants