Repository navigation
Reconnect feeder after request timeout - #4225
Closed
FilipLaurentiu wants to merge 1 commit into
Closed
FilipLaurentiu wants to merge 1 commit into
FilipLaurentiu wants to merge 1 commit into
Conversation
Close idle HTTP connections before retrying timed-out feeder requests so WAN failover can use the new route. Add coverage for a retry after the configured gateway timeout expires. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
This changes are needed in a multi-WAN setup. If the main ISP fail, the second should pick up, so the old connections should be dropped and not tried again |
Contributor
|
Thanks for the PR! While reviewing your PR, I found another way to address the issue, so I've opened #4227, and I'll close this one if you don't mind. |
Author
Definitely ! Thank you for fixing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
go test ./clients/feeder -run TestClientRetryBehavior -count=1go test ./clients/feeder -count=1